Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kafka exporter doc, add instruction to generate ascidoc #242

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Jan 4, 2023

@skrthomas
Copy link
Contributor

/lgtm thank you for making these updates :)

@jotak
Copy link
Member Author

jotak commented Jan 6, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jan 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 6, 2023
@openshift-ci openshift-ci bot added the lgtm label Jan 6, 2023
@openshift-merge-robot openshift-merge-robot merged commit ff9cd22 into netobserv:main Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants