NETOBSERV-772 check volume change in reconcile loop #243
Conversation
jotak
commented
Jan 4, 2023
jotak
commented
- Both for console plugin and FLP, need to check whether volumes changes in reconcile loop
- Some refactoring to share common comparison functions
- Remove namespace comparisons in several places because they are handled differently (namespace changes doesn't trigger the usual workload updates, it deletes all / recreate all)
- Add some tests
- Both for console plugin and FLP, need to check whether volumes changes in reconcile loop - Some refactoring to share common comparison functions - Remove namespace comparisons in several places because they are handled differently (namespace changes doesn't trigger the usual workload updates, it deletes all / recreate all) - Add some tests
There was a problem hiding this comment.
LGTM thanks @jotak !
Tested both CA configmap name change and namespace change.
I found a bug while changing namespace where old ebpf agent in privileged namespace are not deleted
I'm opening a bug since I can reproduce on main branch.
Related slack: https://coreos.slack.com/archives/C02939DP5L5/p1673001363041479
Related jira: https://issues.redhat.com/browse/NETOBSERV-774
|
Thanks Julien |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
