NETOBSERV-684 Watch TLS certs & reload #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some tests
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mariomac
approved these changes
Jan 12, 2023
|
New changes are detected. LGTM label has been removed. |
KalmanMeth
pushed a commit
to KalmanMeth/network-observability-operator
that referenced
this pull request
Feb 13, 2023
* Add integration test for conntrack * Remove a comment * Remove redundant space * Remove layer of abstraction * Workaround for marshalling time.Duration to json * cleanup * Make linter happy * Add details to error * Add abstraction layer for consistency * Replace magic strings with consts * Add fake writer to faciliate integration testing * Move conntrack files under extract * Move conntrack under Extract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CertificatesWatcherthat watches for secrets/configmap changes and triggers reconcile when needed