Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to manifests descriptions #248

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

nathan-weinberg
Copy link
Contributor

Couple of minor changes here for polish - let me know your thoughts!

@jotak
Copy link
Member

jotak commented Jan 12, 2023

Thanks @nathan-weinberg !
Could you run make bundle and add the generated bundle files to the commit?

Basically, when any file that is used in bundle generation is changed, we need to regenerate the bundle and add it to the commit. That's the case with these CSV descriptions
That's why job "pull request checks / Checking bundle up-to-date" failed

@nathan-weinberg
Copy link
Contributor Author

/cc @jotak @jpinsonneau @mariomac

@jotak
Copy link
Member

jotak commented Jan 12, 2023

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Jan 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 50a950b into netobserv:main Jan 12, 2023
KalmanMeth pushed a commit to KalmanMeth/network-observability-operator that referenced this pull request Feb 13, 2023
@nathan-weinberg nathan-weinberg deleted the doc-update branch October 3, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants