NETOBSERV-674 : Added management of prometheus rule #250
Conversation
OlivierCazade
changed the title
OlivierCazade
force-pushed
the
prometheus-rule
branch
from
980448a
to
102f5e7
Compare
|
I would prefer to make it more configurable. It could be annoying if for X reason the alert is triggered as a false positive - this can always happen - we want in this case that the users is able to turn them off, and avoiding the operator to keep creating them. |
| { | ||
| Alert: "NetobservNoFlows", | ||
| Annotations: map[string]string{ | ||
| "description": "Netobserv flowlogs-pipeline is not receiving any flow, this is either a connection issue with the agent, or an agent issue", |
There was a problem hiding this comment.
Can you replace Netobserv with NetObserv (capital O) ? There's the occurrence in several places in this file
|
@jotak since we are still testing how changes in the CRD will be handle, do you mind if I create a following task to add an ignore list entry in the CRD? |
OlivierCazade
force-pushed
the
prometheus-rule
branch
from
3184263
to
5712d38
Compare
|
@OlivierCazade can you create that follow-up task? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: OlivierCazade The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added metrics to kafka ingest
* Added management of prometheus rule * Fix tests after rebase * Added bundle modifications * Fixed NetObserv case in created alerts
This PR add support for PrometheusRule to configure different alerts.
I also added change detection to service monitor which for now, once created, is not checked.