NETOBSERV-793 Change default loki CA configmap name #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will likely be needed in 1.1 |
Changing to "loki-gateway-ca-bundle" so that it matches loki operator 5.6 name
stleerh
approved these changes
Jan 30, 2023
|
/ok-to-test |
|
/label ok-to-test |
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: ["quay.io/netobserv/network-observability-operator:b120adc"]. It will expire after two weeks. |
|
/label qe-approved |
jpinsonneau
approved these changes
Feb 2, 2023
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jotak
added a commit
to jotak/network-observability-operator
that referenced
this pull request
Feb 3, 2023
Changing to "loki-gateway-ca-bundle" so that it matches loki operator 5.6 name
openshift-merge-robot
pushed a commit
that referenced
this pull request
Feb 3, 2023
KalmanMeth
pushed a commit
to KalmanMeth/network-observability-operator
that referenced
this pull request
Feb 13, 2023
* Confgen: init from options (avoid many globals) * Use main model in confgen, use pipeline builder Fixes netobserv#254 - Removed duplicated confgen model - Use PipelineBuilder to simplify pipeline generation - Make confgen easier to consume as a lib (e.g. for NOO) - Do not make it necessary to call "Run": parsing definition files should be sufficient - Do not make it necessary to work with files written on disk: work with []byte instead - SkipWithTags should not result in an error when a file is skipped - Add confgen tests * Avoid using globals A side-effect of removing globals in write_loki is that it changes how the config is read, and set with defaults. Instead of unmarshaling a second time to automatically get defaults, we now call an explicit function that sets the default. Also, now removing loki URL default, it now has to be set explicitely * Update ConnTrack builder * More defer cleanup in tests, and use ioutils / temp dir/files Also fixed jsonnet dir actually used as filename prefix rather than directory * User ConfigFileStruct in confgen * Update pkg/config/config.go Co-authored-by: Ronen Schaffer <ronen.schaffer@ibm.com> * Use config.ConfigFileStruct in tests Co-authored-by: Ronen Schaffer <ronen.schaffer@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing to "loki-gateway-ca-bundle" so that it matches loki operator 5.6 name
JIRA: https://issues.redhat.com/browse/NETOBSERV-793