NETOBSERV-856 Fix infinite reconcile & add more debugging utility #262
Conversation
|
@OlivierCazade @jpinsonneau I'm adding here more logs that help a lot debugging - but there's a drawback, that it is doing more logging stuff at runtime. Maybe we should replace it with logrus, that we use in the other repos, wdyt? (in a next PR) |
There was a problem hiding this comment.
LGTM. I'm fine with the idea of changing the logger in a followup.
FYI in loki-operator they use https://github.com/ViaQ/logerr
* return typed model instead of generic map * exported a few more functions * allowed missing config.yaml file * added ConfigFileSgtruct * restored output of Buckets * changed config2 to config
The infinite reconcile was due to a bad change comparison of liveness/readiness probes. This commit is also adding better reconciliation change tracking utility for debugging.
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: ["quay.io/netobserv/network-observability-operator:9dbe447"]. It will expire after two weeks. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The infinite reconcile was due to a bad change comparison of liveness/readiness probes.
This commit is also adding better reconciliation change tracking utility for debugging.