Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETOBSERV-674: Added alertNamespaces field in console plugin frontend configuration #265

Merged
merged 1 commit into from
Feb 14, 2023
Merged

NETOBSERV-674: Added alertNamespaces field in console plugin frontend configuration #265

merged 1 commit into from
Feb 14, 2023

Conversation

OlivierCazade
Copy link
Contributor

I just realized that I forgot to push the last commit on my previous PR.

This was linked to PR comments to make namespace configuration.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 13, 2023 •
edited by openshift-ci bot

@OlivierCazade: This pull request references NETOBSERV-674 which is a valid jira issue.

In response to this:

I just realized that I forgot to push the last commit on my previous PR.

This was linked to PR comments to make namespace configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jpinsonneau
jpinsonneau approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@openshift-ci openshift-ci bot added the lgtm label Feb 13, 2023
@OlivierCazade
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: OlivierCazade

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 97f58b0 into netobserv:main Feb 14, 2023
memodi pushed a commit to memodi/network-observability-operator that referenced this pull request Feb 16, 2023
@OlivierCazade @memodi
Added alertNamespaces field in console plugin frontend configuration (n…
617dee9 
…etobserv#265)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpinsonneau jpinsonneau jpinsonneau approved these changes

@jotak jotak Awaiting requested review from jotak

Assignees

@jpinsonneau jpinsonneau

Labels
approved jira/valid-reference lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@OlivierCazade @openshift-ci-robot @jpinsonneau @openshift-merge-robot