Fix doc for operator-sdk command & make generate now must be explicit #272
Conversation
jotak
added
no-qe
|
this doesn't work if operator-sdk in your path, in that case it will never get installed at |
|
/hold |
jotak
changed the title
| BIN_DIR := bin | ||
| TOOLS_DIR := hack/tools | ||
| TOOLS_BIN_DIR := $(abspath $(TOOLS_DIR)/$(BIN_DIR)) | ||
| BIN_DIR := $(abspath bin) |
There was a problem hiding this comment.
cc @msherif1234 we already had all our executable tools in ./bin (e.g. operator-sdk ...) , so this is moving conversion-gen to the same place to avoid too much fragmentation
Makefile
Outdated
| GO_INSTALL := ./scripts/go_install.sh | ||
| CONVERSION_GEN_VER := v0.25.0 | ||
| CONVERSION_GEN_BIN := conversion-gen | ||
| # We are intentionally using the binary without version suffix, to avoid the version | ||
| # in generated files. | ||
| CONVERSION_GEN := $(abspath $(TOOLS_BIN_DIR)/$(CONVERSION_GEN_BIN)) | ||
| CONVERSION_GEN := $(abspath $(BIN_DIR)/$(CONVERSION_GEN_BIN)) |
There was a problem hiding this comment.
BIN_DIR is already made absolute on line 114 so no need to do it again here.
CONVERSION_GEN := $(BIN_DIR)/$(CONVERSION_GEN_BIN)
|
/lgtm |
|
thanks, |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When using makefile commands, operator-sdk now is downloaded to bin; not all docs were updated when this change was made, fixing it