Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix netobserv operator bundle deploy #274

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Fix netobserv operator bundle deploy #274

merged 2 commits into from
Feb 21, 2023

Conversation

msherif1234
Copy link
Contributor

FLowCollector object were incorrectly patched with cert mgr OLM doesn't support it hence removing it

Tested regular deploy make deploy as well as make catalog-deploy

@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 17, 2023
@github-actions
Copy link

New image: ["quay.io/netobserv/network-observability-operator:8262ab7"]. It will expire after two weeks.

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 17, 2023
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 17, 2023
@github-actions
Copy link

New image: ["quay.io/netobserv/network-observability-operator:c360122"]. It will expire after two weeks.

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 18, 2023
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 18, 2023
@github-actions
Copy link

New image: ["quay.io/netobserv/network-observability-operator:b6a83f0"]. It will expire after two weeks.

jpinsonneau
jpinsonneau previously approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the VERSION update, else LGTM

Thanks @msherif1234 !

Makefile Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm label Feb 20, 2023
jotak
jotak requested changes Feb 20, 2023
View reviewed changes
Copy link
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(request changes on the modified default version)

@openshift-ci openshift-ci bot removed the lgtm label Feb 20, 2023
@jotak
Copy link
Member

jotak commented Feb 20, 2023

Tested and it worked, thanks!
Happy to merge when the default VERSION is restored

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 20, 2023
@msherif1234 msherif1234 force-pushed the test_bundle branch 2 times, most recently from 90100d8 to a58c975 Compare February 20, 2023 14:49
jotak
jotak reviewed Feb 20, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@msherif1234 msherif1234 force-pushed the test_bundle branch 2 times, most recently from 6fac478 to 46f7b6f Compare February 20, 2023 15:32
@msherif1234
Fix netobserv operator bundle deploy
de19a7d 
FLowCollector object were incorrectly patched with cert mgr
OLM doesn't support it hence removing it

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@jpinsonneau
Copy link
Contributor

/lgtm thanks @msherif1234

@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 20, 2023
@github-actions
Copy link

New image: ["quay.io/netobserv/network-observability-operator:1bd6a77"]. It will expire after two weeks.

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 20, 2023
@jotak
Copy link
Member

jotak commented Feb 20, 2023

@msherif1234 , I added a commit for CI updates (you can take a look)
When this is merged I will double-check everything is ok

@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 20, 2023
@github-actions
Copy link

New image: ["quay.io/netobserv/network-observability-operator:e414610"]. It will expire after two weeks.

@jotak
Copy link
Member

jotak commented Feb 21, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Feb 21, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f5bddd1 into netobserv:main Feb 21, 2023
jotak added a commit to jotak/network-observability-operator that referenced this pull request Feb 28, 2023
@jotak
Fix regression on deploying latest
c92f224 
In netobserv#274
the way IMG is used is changed, which broke deploying all latest
components

This patch introduces a new "deploy-latest" target to explicitly deploy
all components on their `main` branches
@jotak jotak mentioned this pull request Feb 28, 2023
Merged
openshift-merge-robot pushed a commit that referenced this pull request Mar 1, 2023
@jotak
Fix regression on deploying latest (#280)
1b5925f 
* Fix regression on deploying latest

In #274
the way IMG is used is changed, which broke deploying all latest
components

This patch introduces a new "deploy-latest" target to explicitly deploy
all components on their `main` branches

* Use gsed or sed; update doc
@msherif1234 msherif1234 mentioned this pull request Mar 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpinsonneau jpinsonneau jpinsonneau left review comments

@jotak jotak Awaiting requested review from jotak

Assignees

@jotak jotak

@jpinsonneau jpinsonneau

Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@msherif1234 @jotak @jpinsonneau @openshift-merge-robot