Fix deployment on non-ovnk (e.g. kind) #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotak
added
no-qe
|
This bug was seen while testing the bundle on KIND (for upstream release). As a result I did not release 1.0.2 on non-openshift operatorhub |
msherif1234
reviewed
Feb 21, 2023
| }, ds); err != nil { | ||
| if kerr.IsNotFound(err) && !target.Spec.UseIPFIX() { | ||
| // If we don't want IPFIX and ovn-k daemonset is not found, assume there no ovn-k, just succeed silently | ||
| return nil |
There was a problem hiding this comment.
can we add a log info message here just stating non ovn-kubernetes mode ? will probably be handy when look in the logs ?
|
/lgtm |
|
Thanks @msherif1234 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exit silently when ovn-k workloads aren't found, when they are not required