NETOBSERV-736: Added downstream deployment configuration for monitoring collection

[OlivierCazade]

Add downstream configuration boolean.

To override this boolean run: make set-release-kind-downstream

This PR does not change the HTTPS config for the operator metrics endpoint but I did not want to overload the PR, I will do another PR about it.

[openshift-ci-robot]

@OlivierCazade: This pull request references NETOBSERV-736 which is a valid jira issue.

In response to this:

Add downstream configuration boolean.

To override this boolean run: make set-release-kind-downstream

This PR does not change the HTTPS config for the operator metrics endpoint but I did not want to overload the PR, I will do another PR about it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[memodi]

would DOWNSTREAM_DEPLOYMENT be set to true in CPAAS pipeline stages?

[OlivierCazade]

Yes, the last step for this task is to update downstream build to change DOWNSTREAM_DEPLOYMENT
We already do this kind of changes for container images such as RELATED_IMAGE_CONSOLE_PLUGIN

[memodi]

got it, thanks!. Could you open a PR for downstream setting this env to true?

we'd have to test this PR post-merge cc @jotak

[memodi]

/ok-to-test

[github-actions]

New image: ["quay.io/netobserv/network-observability-operator:21c52d0"]. It will expire after two weeks.

[memodi]

@OlivierCazade - I am not sure I am testing this the right way:

1. I modified manager.yaml to set DOWNSTREAM_DEPLOYMENT == true
2. deployed image from this PR
3. applied serviceMonitor as described in PR Enable operator metrics collection #273 in NS netobserv

$ oc get servicemonitor
NAME              AGE
metrics-monitor   25m

but I am not able to see metrics for NOO when I go under Observe --> Metrics on Console, could you let me know what am I missing in above procedure? Also, this PR needs a rebase.

[memodi]

thanks @OlivierCazade , this info helped:

PR #282 is about tagging the namespace so the platform monitoring stack collect the metrics and not the user workload monitoring stack.
If you want operator metrics, yes you will need both PR, but what you should see by testing 282 alone is the metrics from FLP getting collected automatically without enabling user workload monitoring.

I am able to see FLP metrics based off changes in this PR, modified DOWNSTREAM_DEPLOYMENT to set to true in manager.yaml , will re-test for downstream build

/label qe-approved

[jotak]

lgtm (not tested)

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (main@176f7d9). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #282   +/-   ##
=======================================
  Coverage        ?   47.38%           
=======================================
  Files           ?       43           
  Lines           ?     4947           
  Branches        ?        0           
=======================================
  Hits            ?     2344           
  Misses          ?     2395           
  Partials        ?      208           

Flag	Coverage Δ
unittests	47.38% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[jotak]

/lgtm

[OlivierCazade]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: OlivierCazade

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [OlivierCazade]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment