-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-736: Added downstream deployment configuration for monitoring collection #282
NETOBSERV-736: Added downstream deployment configuration for monitoring collection #282
Conversation
@OlivierCazade: This pull request references NETOBSERV-736 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -649,6 +653,8 @@ spec: | |||
value: quay.io/netobserv/flowlogs-pipeline:v0.1.8 | |||
- name: RELATED_IMAGE_CONSOLE_PLUGIN | |||
value: quay.io/netobserv/network-observability-console-plugin:v0.1.9 | |||
- name: DOWNSTREAM_DEPLOYMENT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would DOWNSTREAM_DEPLOYMENT
be set to true in CPAAS pipeline stages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the last step for this task is to update downstream build to change DOWNSTREAM_DEPLOYMENT
We already do this kind of changes for container images such as RELATED_IMAGE_CONSOLE_PLUGIN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, thanks!. Could you open a PR for downstream setting this env to true?
we'd have to test this PR post-merge cc @jotak
/ok-to-test |
New image: ["quay.io/netobserv/network-observability-operator:21c52d0"]. It will expire after two weeks. |
@OlivierCazade - I am not sure I am testing this the right way:
but I am not able to see metrics for NOO when I go under |
thanks @OlivierCazade , this info helped:
I am able to see FLP metrics based off changes in this PR, modified /label qe-approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (not tested)
d578cef
to
aa42b1a
Compare
Codecov Report
@@ Coverage Diff @@
## main #282 +/- ##
=======================================
Coverage ? 47.38%
=======================================
Files ? 43
Lines ? 4947
Branches ? 0
=======================================
Hits ? 2344
Misses ? 2395
Partials ? 208
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: OlivierCazade The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add downstream configuration boolean.
To override this boolean run:
make set-release-kind-downstream
This PR does not change the HTTPS config for the operator metrics endpoint but I did not want to overload the PR, I will do another PR about it.