Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETOBSERV-897 Report coverage #287

Merged
merged 1 commit into from
Mar 3, 2023
Merged

NETOBSERV-897 Report coverage #287

merged 1 commit into from
Mar 3, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Mar 2, 2023

No description provided.

@msherif1234
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Mar 2, 2023
@jotak
Copy link
Member Author

jotak commented Mar 3, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak, msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit d6dfe83 into netobserv:main Mar 3, 2023
@jotak
Copy link
Member Author

jotak commented Mar 3, 2023

Note: we should, the engineering team, take some time to review where tests are missing. I don't think we should aim for a precise percentage of coverage: this is known to be counter-productive (this is a very flawed metric to measure quality, however this is a good tool to help analyze coverage lacks. To know more about what test coverage provide and do not provide, refer to Martin Fowler's TestCoverage or Brian Marick's How To Misuse Code Coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@msherif1234 msherif1234

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jotak @msherif1234 @openshift-merge-robot