Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix operator for FLP breaking changes #289

Merged

Conversation

jotak
Copy link
Member

@jotak jotak commented Mar 8, 2023

@jotak jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@d6dfe83). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #289   +/-   ##
=======================================
  Coverage        ?   47.42%           
=======================================
  Files           ?       43           
  Lines           ?     4951           
  Branches        ?        0           
=======================================
  Hits            ?     2348           
  Misses          ?     2395           
  Partials        ?      208           
Flag Coverage Δ
unittests 47.42% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KalmanMeth
Copy link
Contributor

The code update looks good to me. I did not run this update with the updated flp to test that it works properly.

@jotak
Copy link
Member Author

jotak commented Mar 8, 2023

thanks @OlivierCazade @KalmanMeth
/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 8, 2023
@openshift-merge-robot openshift-merge-robot merged commit 503646d into netobserv:main Mar 8, 2023
@jotak jotak deleted the update-for-flp-metrics-breaking branch March 13, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants