Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-916 Higher CPU utilization seen due to connection tracking #297

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

jpinsonneau
Copy link
Contributor

Added more outputRecordTypes options:

  • FLOWS
  • CONNECTIONS
  • ENDED_CONNECTIONS
  • ALL

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #297 (d487009) into main (8a4db3c) will increase coverage by 0.03%.
The diff coverage is 51.61%.

❗ Current head d487009 differs from pull request most recent head 1fed7c9. Consider uploading reports for the commit 1fed7c9 to get more accurate results

@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
+ Coverage   47.61%   47.65%   +0.03%     
==========================================
  Files          43       43              
  Lines        5015     5030      +15     
==========================================
+ Hits         2388     2397       +9     
- Misses       2416     2423       +7     
+ Partials      211      210       -1     
Flag Coverage Δ
unittests 47.65% <51.61%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/v1beta1/flowcollector_types.go 100.00% <ø> (ø)
pkg/helper/flowcollector.go 61.70% <46.15%> (-19.26%) ⬇️
controllers/consoleplugin/consoleplugin_objects.go 80.00% <50.00%> (+2.11%) ⬆️
controllers/flowlogspipeline/flp_common_objects.go 85.21% <100.00%> (-0.10%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jpinsonneau
Copy link
Contributor Author

/retest

@Amoghrd
Copy link
Contributor

Amoghrd commented Mar 16, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 16, 2023
@github-actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:218b284
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-218b284
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-218b284

They will expire after two weeks.

Catalog source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-218b284
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@Amoghrd
Copy link
Contributor

Amoghrd commented Mar 16, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Mar 16, 2023
@jpinsonneau
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 44e1b37 into netobserv:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants