Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TCP flags handling in FLP #305

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

ronensc
Copy link
Contributor

@ronensc ronensc commented Mar 22, 2023

This PR is a follow up on:
netobserv/flowlogs-pipeline#391

@ronensc ronensc added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 22, 2023
@github-actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:8e3a841
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-8e3a841
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-8e3a841

They will expire after two weeks.

Catalog source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-8e3a841
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #305 (c89b2e6) into main (1b56f8e) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   49.62%   49.67%   +0.04%     
==========================================
  Files          43       43              
  Lines        5070     5075       +5     
==========================================
+ Hits         2516     2521       +5     
  Misses       2343     2343              
  Partials      211      211              
Flag Coverage Δ
unittests 49.67% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/flowlogspipeline/flp_common_objects.go 85.28% <100.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ronensc ronensc marked this pull request as ready for review March 22, 2023 16:04
@jpinsonneau
Copy link
Contributor

Related to NETOBSERV-915

Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ronensc

@ronensc
Copy link
Contributor Author

ronensc commented Mar 23, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ronensc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f3cc255 into netobserv:main Mar 23, 2023
@ronensc ronensc deleted the tcp-flags branch March 23, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants