Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-904: Make v1beta1 the storage version #308

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Mar 24, 2023

since we have now a release out with v1beta1, its time to make v1beta1 as the storage apis version

tested on OCP cluster

oc get flowcollectors
NAME      AGENT   SAMPLING (EBPF)   DEPLOYMENT MODEL   STATUS
cluster   EBPF    50                DIRECT             Ready

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 24, 2023

@msherif1234: This pull request references NETOBSERV-904 which is a valid jira issue.

In response to this:

since we have now a release out with v1beta1, its time to make it v1beta1 as the storage apis version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msherif1234 msherif1234 requested a review from jotak March 24, 2023 15:24
@msherif1234 msherif1234 changed the title NETOBSERV-904: Make v1beta1 the stored version NETOBSERV-904: Make v1beta1 the storage version Mar 24, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 24, 2023

@msherif1234: This pull request references NETOBSERV-904 which is a valid jira issue.

In response to this:

since we have now a release out with v1beta1, its time to make v1beta1 as the storage apis version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #308 (bd84b30) into main (f3cc255) will increase coverage by 0.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
+ Coverage   49.67%   50.10%   +0.43%     
==========================================
  Files          43       43              
  Lines        5075     5075              
==========================================
+ Hits         2521     2543      +22     
+ Misses       2344     2325      -19     
+ Partials      210      207       -3     
Flag Coverage Δ
unittests 50.10% <ø> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/v1alpha1/flowcollector_types.go 100.00% <ø> (ø)
api/v1beta1/flowcollector_types.go 100.00% <ø> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 24, 2023

@msherif1234: This pull request references NETOBSERV-904 which is a valid jira issue.

In response to this:

since we have now a release out with v1beta1, its time to make v1beta1 as the storage apis version

tested on OCP cluster

oc get flowcollectors
NAME      AGENT   SAMPLING (EBPF)   DEPLOYMENT MODEL   STATUS
cluster   EBPF    50                DIRECT             Ready

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 25, 2023
@github-actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:e204644
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-e204644
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-e204644

They will expire after two weeks.

Catalog source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-e204644
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@openshift-ci openshift-ci bot added the lgtm label Mar 28, 2023
@jotak jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Mar 30, 2023
@jotak
Copy link
Member

jotak commented Mar 30, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e1532e4 into netobserv:main Mar 30, 2023
msherif1234 added a commit to msherif1234/network-observability-operator that referenced this pull request Mar 31, 2023
* NETOBSERV-904: Make v1beta1 the stored version

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

* use none default value when update flowcollector object to recreate SM

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

---------

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/valid-reference lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants