Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change metrics rates calculations from 5m to 1m #314

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions controllers/flowlogspipeline/flp_common_objects.go
Original file line number Diff line number Diff line change
Expand Up @@ -741,7 +741,7 @@ func (b *builder) prometheusRule() *monitoringv1.PrometheusRule {
"description": "NetObserv flowlogs-pipeline is not receiving any flow, this is either a connection issue with the agent, or an agent issue",
"summary": "NetObserv flowlogs-pipeline is not receiving any flow",
},
Expr: intstr.FromString("sum(rate(netobserv_ingest_flows_processed[5m])) == 0"),
Expr: intstr.FromString("sum(rate(netobserv_ingest_flows_processed[1m])) == 0"),
For: "10m",
Labels: map[string]string{
"severity": "warning",
Expand All @@ -758,7 +758,7 @@ func (b *builder) prometheusRule() *monitoringv1.PrometheusRule {
"description": "NetObserv flowlogs-pipeline is dropping flows because of loki errors, loki may be down or having issues ingesting every flows. Please check loki and flowlogs-pipeline logs.",
"summary": "NetObserv flowlogs-pipeline is dropping flows because of loki errors",
},
Expr: intstr.FromString("sum(rate(netobserv_loki_dropped_entries_total[5m])) > 0"),
Expr: intstr.FromString("sum(rate(netobserv_loki_dropped_entries_total[1m])) > 0"),
For: "10m",
Labels: map[string]string{
"severity": "warning",
Expand Down
6 changes: 3 additions & 3 deletions controllers/infra_health_dashboard.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,21 +66,21 @@
"steppedLine":false,
"targets":[
{
"expr":"sum(rate(netobserv_ingest_flows_processed[5m]))",
"expr":"sum(rate(netobserv_ingest_flows_processed[1m]))",
"format":"time_series",
"intervalFactor":2,
"legendFormat":"Flows ingested",
"refId":"A"
},
{
"expr":"sum(rate(netobserv_loki_sent_entries_total[5m]))",
"expr":"sum(rate(netobserv_loki_sent_entries_total[1m]))",
"format":"time_series",
"intervalFactor":2,
"legendFormat":"Flows sent to loki",
"refId":"A"
},
{
"expr":"sum(rate(netobserv_loki_dropped_entries_total[5m]))",
"expr":"sum(rate(netobserv_loki_dropped_entries_total[1m]))",
"format":"time_series",
"intervalFactor":2,
"legendFormat":"Flows dropped due to loki error",
Expand Down