Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-976 Fix disabling alerts #328

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Apr 19, 2023

No description provided.

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #328 (cb460a4) into main (36de463) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
+ Coverage   50.90%   51.07%   +0.16%     
==========================================
  Files          43       43              
  Lines        5080     5081       +1     
==========================================
+ Hits         2586     2595       +9     
+ Misses       2293     2287       -6     
+ Partials      201      199       -2     
Flag Coverage Δ
unittests 51.07% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/helper/comparators.go 77.77% <100.00%> (+0.31%) ⬆️

... and 2 files with indirect coverage changes

@Amoghrd
Copy link
Contributor

Amoghrd commented Apr 20, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 20, 2023
@github-actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:2371507
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-2371507
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-2371507

They will expire after two weeks.

Catalog source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-2371507
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

Copy link
Contributor

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks.

LGTM

@Amoghrd
Copy link
Contributor

Amoghrd commented Apr 25, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Apr 25, 2023
@jpinsonneau
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Apr 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpinsonneau jpinsonneau merged commit a6c1cc2 into netobserv:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants