Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list of maintainers #332

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

jotak
Copy link
Member

@jotak jotak commented May 2, 2023

The list hasn't been updated since the begining ... Need to credit new folks and remove former maintainer (Mario)

The list hasn't been updated since the begining ... Need to credit new
folks and remove former maintainer (Mario)
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #332 (be4e0b9) into main (c2c2961) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   51.34%   51.34%           
=======================================
  Files          43       43           
  Lines        5155     5155           
=======================================
  Hits         2647     2647           
  Misses       2310     2310           
  Partials      198      198           
Flag Coverage Δ
unittests 51.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@msherif1234
Copy link
Contributor

/lgtm

@jotak
Copy link
Member Author

jotak commented May 10, 2023

/approve

@jotak jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels May 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 11fc116 into netobserv:main May 10, 2023
@jotak jotak deleted the maintainers branch June 14, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants