NETOBSERV-1003: Added monitoring role to bundle

[OlivierCazade]

Add monitoring role to the bundle.

[openshift-ci-robot]

@OlivierCazade: This pull request references NETOBSERV-1003 which is a valid jira issue.

In response to this:

Add monitoring role to the bundle.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[OlivierCazade]

/hold

Testing

[OlivierCazade]

/ok-to-test

[github-actions]

New images:

• quay.io/netobserv/network-observability-operator:589bbb4
• quay.io/netobserv/network-observability-operator-bundle:v0.0.0-589bbb4
• quay.io/netobserv/network-observability-operator-catalog:v0.0.0-589bbb4

They will expire after two weeks.

Catalog source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-589bbb4
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

[codecov]

Codecov Report

Merging #333 (336f3f1) into main (c2c2961) will not change coverage.
The diff coverage is n/a.

❗ Current head 336f3f1 differs from pull request most recent head 5db3663. Consider uploading reports for the commit 5db3663 to get more accurate results

@@           Coverage Diff           @@
##             main     #333   +/-   ##
=======================================
  Coverage   51.34%   51.34%           
=======================================
  Files          43       43           
  Lines        5155     5155           
=======================================
  Hits         2647     2647           
  Misses       2310     2310           
  Partials      198      198           

Flag	Coverage Δ
unittests	51.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[memodi]

LGTM
I tried testing using make-deploy but it did not deploy operator in openshift-netobserv-operator NS and also had to update DOWNSTREAM_DEPLOYMENT variable. If your testing so far looks good. I think we should go ahead merge it and can do further testing on Downstream builds.

/label qe-approved

[memodi]

LGTM I tried testing using make-deploy but it did not deploy operator in openshift-netobserv-operator NS and also had to update DOWNSTREAM_DEPLOYMENT variable.

never mind I was able to work with catalog image on this PS and edit CSV for DOWNSTREAM_DEPLOYMENT, Operator metrics were being populated correctly. Thanks!

[msherif1234]

@OlivierCazade do u think it’s better to group role and role_binding for Prometheus with the rest under Config/rbac folder ?

[OlivierCazade]

@msherif1234 config/rbac is general and used in every kind of deployment. The monitoring part is proper to Openshift this is why I added the rules there to avoid deploying unnecessary rule.

[jotak]

shouldn't it be in the config/openshift-olm directory? I'm a bit confused.. I think openshift-olm is the one used for downstream builds.. Maybe add it in both places ?

[OlivierCazade]

@jotak done, thanks

[jotak]

/lgtm

[OlivierCazade]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: OlivierCazade

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [OlivierCazade]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[OlivierCazade]

/unhold