Attempt to fix multiarch workflow

[jotak]

Shortlived images are now built from scratch, not from a base. (Same can be done later for bundle & catalog)

It simplifies the workflows especially with multiarch. We don't need anymore the "ci*" make targets.

Restore the SHA-builds on merged commits

Also make multiarch configurable, and only for merged commits, not per PR

[codecov]

Codecov Report

Merging #342 (8d080ba) into main (7bf6bbc) will not change coverage.
The diff coverage is n/a.

❗ Current head 8d080ba differs from pull request most recent head e998895. Consider uploading reports for the commit e998895 to get more accurate results

@@           Coverage Diff           @@
##             main     #342   +/-   ##
=======================================
  Coverage   51.42%   51.42%           
=======================================
  Files          43       43           
  Lines        5186     5186           
=======================================
  Hits         2667     2667           
  Misses       2323     2323           
  Partials      196      196           

Flag	Coverage Δ
unittests	51.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[jotak]

per-PR workflow tested here: https://github.com/netobserv/network-observability-operator/actions/runs/5059748527/jobs/9081725300?pr=343
This one seems good.
We'll need also to check post-merge workflow

[jotak]

If we agree on that we should make similar changes in the other repos

[jotak]

hold on ... there's something fishy ; the generated bundle seems wrong, its containerImage is odd

[jotak]

next try: #344

[msherif1234]

LGTM

[jotak]

Hey @msherif1234 - added two more commits:

• one to allow testing on a specific branch, workflow-test, that will also trigger the post-merge workflow
• a final one to document all of that

So I think I'm done with this PR, although (as said on slack) I've found new issues related to multi-arch - but that's not related to this PR, I think it can still be merged

[jotak]

thanks @jpinsonneau @msherif1234 !
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jotak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment