Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundle and catalog push GH actions #346

Merged
merged 3 commits into from
May 26, 2023

Conversation

msherif1234
Copy link
Contributor

No description provided.

Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #346 (805d6a4) into main (d623e5b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #346   +/-   ##
=======================================
  Coverage   51.42%   51.42%           
=======================================
  Files          43       43           
  Lines        5186     5186           
=======================================
  Hits         2667     2667           
  Misses       2323     2323           
  Partials      196      196           
Flag Coverage Δ
unittests 51.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@msherif1234 msherif1234 changed the base branch from main to workflow-test May 25, 2023 20:51
@msherif1234 msherif1234 changed the base branch from workflow-test to main May 25, 2023 20:51
@msherif1234 msherif1234 changed the title update bundle and catalog push GH actions WIP: update bundle and catalog push GH actions May 25, 2023
jotak added 2 commits May 26, 2023 12:26
Switch to more direct way to build shortlived bundle
Catalog had to stay with a temporary dockerfile ...
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 26, 2023
@jotak
Copy link
Member

jotak commented May 26, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 26, 2023
@msherif1234 msherif1234 changed the title WIP: update bundle and catalog push GH actions Update bundle and catalog push GH actions May 26, 2023
@msherif1234
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented May 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d96d1ae into netobserv:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants