Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundle and PR tests #353

Merged
merged 2 commits into from
May 26, 2023

Conversation

OlivierCazade
Copy link
Contributor

No description provided.

@OlivierCazade
Copy link
Contributor Author

I did not add the missing files first to ensure the test is working now.

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #353 (2cfa671) into main (d623e5b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #353   +/-   ##
=======================================
  Coverage   51.42%   51.42%           
=======================================
  Files          43       43           
  Lines        5186     5186           
=======================================
  Hits         2667     2667           
  Misses       2323     2323           
  Partials      196      196           
Flag Coverage Δ
unittests 51.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@OlivierCazade
Copy link
Contributor Author

Tests detected the missing files, adding the files now.

Copy link
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@OlivierCazade
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented May 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: OlivierCazade

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 910d3f4 into netobserv:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants