NETOBSERV-1053 optionnal loki / console plugin #354
Conversation
| @@ -94,6 +95,7 @@ spec: | |||
| maxBackoff: 5s | |||
| maxRetries: 2 | |||
| consolePlugin: | |||
| enable: true | |||
There was a problem hiding this comment.
I feel it would be usefull to be able to disable console plugin even using Loki.
WDYT ?
There was a problem hiding this comment.
why not
a downside is adding more settings always makes it feels more complicated to the user - I think we tend to have a bunch of never-used settings that over-complicate the experience
but a "enable" flag looks simple enough to understand so that's fine with me :-)
Codecov Report
@@ Coverage Diff @@
## main #354 +/- ##
==========================================
+ Coverage 53.58% 53.68% +0.09%
==========================================
Files 45 45
Lines 5488 5510 +22
==========================================
+ Hits 2941 2958 +17
- Misses 2337 2342 +5
Partials 210 210
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Thanks! |
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New images:
They will expire after two weeks. Catalog source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-d7d492d
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
|
@jpinsonneau Could you rebase this PR? I can go ahead testing it once thats done |
| enable: | ||
| default: true | ||
| description: enable the console plugin deployment. spec.Loki.enable | ||
| must be true |
There was a problem hiding this comment.
Is it better if it says must also be true?
There was a problem hiding this comment.
Why not 😄
d902fc6
|
/label qe-approved |
openshift-ci
bot
added
qe-approved
github-actions
bot
removed
the
ok-to-test
@Amoghrd Did you test it anyways ? I've rebased the code and addressed your feedback. |
|
Yeah I tested it before rebasing. But will just test again just to be sure everything is working fine after too. |
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New images:
They will expire after two weeks. Catalog source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-3c8afad
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
|
Tested after rebase, works as expected! |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpinsonneau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added
enableoptions on both Loki and ConsolePlugin CR sections. Defaulttrue.