NETOBSERV-1005 dashboard: use sum...by #356
Conversation
- Fix metrics aggregations by using sum...by - Do not split by FLP pod reporter as it's an implementation detail
Codecov Report
@@ Coverage Diff @@
## main #356 +/- ##
==========================================
+ Coverage 53.37% 53.90% +0.52%
==========================================
Files 45 45
Lines 5328 5328
==========================================
+ Hits 2844 2872 +28
+ Misses 2281 2256 -25
+ Partials 203 200 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New images:
They will expire after two weeks. Catalog source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-f46fd7e
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
|
@jotak this overall looks good to me. It would have been nice to have it limited to Top 5 with Also, could we do something about those empty parentheses? quick search online I didn't find any straightforward solution to handle this in prometheus query. For our netflow-traffic page, we do that by replacing it with
So if no further changes are being added to this PR treat this as |
|
@memodi there's probably something we can do with label_replace , I'll make a try |
github-actions
bot
removed
the
ok-to-test
jotak
added
the
ok-to-test
|
@memodi so my last commit should address your second comment. On the first one (the top5 thing), yeah I didn't find a way to force restricting 5 outputs, and anyway I thought having a bit more than 5 could be interesting, hence I just removed the "Top 5" mention from the title |
|
New images:
They will expire after two weeks. Catalog source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-c240674
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
|
let me try one last thing: I'd like to remove the node-to-node or external-to-node traffic from the workloads-kind of metrics |
github-actions
bot
removed
the
ok-to-test
jotak
added
the
ok-to-test
|
Ok, I've modified the "workloads" graph to exclude node-to-node traffic, so it's not overlapping with the other graph dedicated to nodes
wdyt? |
|
New images:
They will expire after two weeks. Catalog source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-79f0c6f
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
I am yet to try, but this looks great :D , thank you! |
|
/lgtm |
|
thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1.3 backport: #358