Refactor bundling for upstream operatorhub releases #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #363 +/- ##
=======================================
Coverage 53.58% 53.58%
=======================================
Files 45 45
Lines 5488 5488
=======================================
Hits 2941 2941
- Misses 2337 2338 +1
+ Partials 210 209 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
OlivierCazade
approved these changes
Jun 28, 2023
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundling on upstream k8S operatorhub was broken for a while (we didn't release 1.0.2 as we did on openshift's operatorhub)
These changes bring back a non-openshift OLM bundle target (it allowed to get this PR merged: k8s-operatorhub/community-operators#2850 )
The tl;dr is: kustomize files have been moved around to permit building two different OLM bundles, the one for openshift as usual (e.g. with
make bundle-updateas usual) and the one for https://github.com/k8s-operatorhub/community-operators, withBUNDLE_CONFIG=config/k8s-olm make bundle-updateI've also added some automation around the operatorhub release (
make prepare-operatorhub) and updated the RELEASE.md doc