-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix outdated upstream doc on user access #373
Conversation
Codecov Report
@@ Coverage Diff @@
## main #373 +/- ##
=======================================
Coverage 53.54% 53.54%
=======================================
Files 45 45
Lines 5381 5381
=======================================
Hits 2881 2881
Misses 2294 2294
Partials 206 206
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
||
- Connections to Loki (from the processor `flowlogs-pipeline` and from the Console plugin), by setting `spec.loki.tls`. | ||
- With Kafka (both on producer and consumer sides), by setting `spec.kafka.tls`. Mutual TLS is supported here. | ||
- The metrics server running in the processor (`flowlogs-pipeline`) can listen using TLS, via `spec.processor.metrics.server.tls`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The metrics server running in the processor (`flowlogs-pipeline`) can listen using TLS, via `spec.processor.metrics.server.tls`. | |
- The metrics server (running in the processor `flowlogs-pipeline`) can listen using TLS, via `spec.processor.metrics.server.tls`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @jpinsonneau
I didn't take that one: there's several metrics servers (in flp but also in console plugin and in the operator) so I think parenthesis should be kept just around "flowlogs-pipeline"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just small suggestions. Feel free to pick some on these 👍
Co-authored-by: Julien Pinsonneau <91894519+jpinsonneau@users.noreply.github.com>
New changes are detected. LGTM label has been removed. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.