Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outdated upstream doc on user access #373

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Conversation

jotak
Copy link
Member

@jotak jotak commented Jun 14, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #373 (562a499) into main (92e78be) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #373   +/-   ##
=======================================
  Coverage   53.54%   53.54%           
=======================================
  Files          45       45           
  Lines        5381     5381           
=======================================
  Hits         2881     2881           
  Misses       2294     2294           
  Partials      206      206           
Flag Coverage Δ
unittests 53.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved

- Connections to Loki (from the processor `flowlogs-pipeline` and from the Console plugin), by setting `spec.loki.tls`.
- With Kafka (both on producer and consumer sides), by setting `spec.kafka.tls`. Mutual TLS is supported here.
- The metrics server running in the processor (`flowlogs-pipeline`) can listen using TLS, via `spec.processor.metrics.server.tls`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- The metrics server running in the processor (`flowlogs-pipeline`) can listen using TLS, via `spec.processor.metrics.server.tls`.
- The metrics server (running in the processor `flowlogs-pipeline`) can listen using TLS, via `spec.processor.metrics.server.tls`.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jpinsonneau
I didn't take that one: there's several metrics servers (in flp but also in console plugin and in the operator) so I think parenthesis should be kept just around "flowlogs-pipeline"

README.md Outdated Show resolved Hide resolved
jpinsonneau
jpinsonneau previously approved these changes Jun 16, 2023
Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just small suggestions. Feel free to pick some on these 👍

Co-authored-by: Julien Pinsonneau <91894519+jpinsonneau@users.noreply.github.com>
@openshift-ci openshift-ci bot removed the lgtm label Jun 16, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 16, 2023

New changes are detected. LGTM label has been removed.

@jotak
Copy link
Member Author

jotak commented Jun 16, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak merged commit 0e58e62 into netobserv:main Jun 16, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants