NETOBSERV-1076 Fix CR stuck in Updating state [1.3 backport] #375
Conversation
The problem was that copying certificates across namespaces was done on every reconciliation call, with or without digest change. This is not a critical issue as it would only trigger a no-op update, but it was screwing up our "updating" state detection. There's actually two changes in this commit: 1. Fixing the "Updating" flag, so that it's not set when an update is actually performed (we need to fetch back the object (from cache) and check if the resource version was actually modified) 2. Fixing the certificate watching process to avoid unnecessary tries to update Also: - Add / fix tests - Modify some logs to make important information more visible - Makefile change for building manifest without error (unrelated)
Codecov Report
@@ Coverage Diff @@
## release-1.3 #375 +/- ##
==============================================
Coverage ? 54.17%
==============================================
Files ? 45
Lines ? 5403
Branches ? 0
==============================================
Hits ? 2927
Misses ? 2272
Partials ? 204
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
/lgtm |
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
jotak
added
ok-to-test
|
@Amoghrd I think we didn't backport to 1.3 branch the various fixes that we did regarding the ok-to-test workflow ... so maybe it can be verified post-merge, on the downstream build directly? (given you verified already the PR on |
|
/label qe-approved |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Backport of #374
The problem was that copying certificates across namespaces was done on every reconciliation call, with or without digest change. This is not a critical issue as it would only trigger a no-op update, but it was screwing up our "updating" state detection.
There's actually two changes in this commit:
Also: