-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-974: Add SASL support for KAFKA (unsupported feature) #377
Conversation
@jotak: This pull request references NETOBSERV-974 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## main #377 +/- ##
==========================================
+ Coverage 53.39% 53.60% +0.21%
==========================================
Files 45 45
Lines 5381 5466 +85
==========================================
+ Hits 2873 2930 +57
- Misses 2303 2330 +27
- Partials 205 206 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Removing an Env was missed in reconciliation due to using DeepDerivative
For info, I found a bug in the agent reconciler fixed in the last commit, not specific to this PR - if for some reason we delay merging this PR, I would need to open another one (but given it's marked as "unsupported" I don't think there's reasons to not merge it?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM, thanks @jotak
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.