Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-974: Add SASL support for KAFKA (unsupported feature) #377

Merged
merged 3 commits into from
Jun 22, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Jun 20, 2023

No description provided.

@jotak jotak requested a review from jpinsonneau June 20, 2023 06:39
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 20, 2023

@jotak: This pull request references NETOBSERV-974 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #377 (6a1c6f4) into main (0e58e62) will increase coverage by 0.21%.
The diff coverage is 47.19%.

@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
+ Coverage   53.39%   53.60%   +0.21%     
==========================================
  Files          45       45              
  Lines        5381     5466      +85     
==========================================
+ Hits         2873     2930      +57     
- Misses       2303     2330      +27     
- Partials      205      206       +1     
Flag Coverage Δ
unittests 53.60% <47.19%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/v1alpha1/flowcollector_webhook.go 0.00% <0.00%> (ø)
api/v1alpha1/zz_generated.conversion.go 0.26% <ø> (ø)
api/v1beta1/flowcollector_types.go 100.00% <ø> (ø)
api/v1beta1/zz_generated.deepcopy.go 51.62% <0.00%> (-2.52%) ⬇️
controllers/ebpf/agent_controller.go 80.54% <28.57%> (-5.24%) ⬇️
controllers/flowlogspipeline/flp_reconciler.go 69.51% <62.50%> (-4.82%) ⬇️
controllers/flowlogspipeline/flp_common_objects.go 86.60% <80.00%> (-0.16%) ⬇️
...ontrollers/flowlogspipeline/flp_transfo_objects.go 93.68% <100.00%> (+0.06%) ⬆️
pkg/helper/flowcollector.go 67.14% <100.00%> (+0.96%) ⬆️
pkg/volumes/builder.go 100.00% <100.00%> (+4.44%) ⬆️
... and 2 more

... and 2 files with indirect coverage changes

Removing an Env was missed in reconciliation due to using DeepDerivative
@jotak
Copy link
Member Author

jotak commented Jun 20, 2023

For info, I found a bug in the agent reconciler fixed in the last commit, not specific to this PR - if for some reason we delay merging this PR, I would need to open another one (but given it's marked as "unsupported" I don't think there's reasons to not merge it?)

@jotak jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Jun 20, 2023
@jotak jotak changed the title NETOBSERV-974: Add SASL support for KAFKA NETOBSERV-974: Add SASL support for KAFKA (unsupported feature) Jun 20, 2023
Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM, thanks @jotak

@jotak
Copy link
Member Author

jotak commented Jun 22, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ad24dde into netobserv:main Jun 22, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/valid-reference lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants