Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1107: Add GoMemLimit env setting to prevent ebpf agent OOM conditions #382

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Jun 21, 2023

@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #382 (5a53e6e) into main (651249e) will decrease coverage by 0.52%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
- Coverage   55.04%   54.52%   -0.52%     
==========================================
  Files          44       44              
  Lines        5416     5423       +7     
==========================================
- Hits         2981     2957      -24     
- Misses       2232     2259      +27     
- Partials      203      207       +4     
Flag Coverage Δ
unittests 54.52% <100.00%> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/ebpf/agent_controller.go 81.06% <100.00%> (+0.51%) ⬆️

... and 5 files with indirect coverage changes

@github-actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:d6f53b8
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-d6f53b8
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-d6f53b8

They will expire after two weeks.

Catalog source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-d6f53b8
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jun 21, 2023
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jun 21, 2023
@github-actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:ab67fc4
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-ab67fc4
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-ab67fc4

They will expire after two weeks.

Catalog source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-ab67fc4
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@msherif1234 msherif1234 changed the title Add GoMemLimit env setting to prevent ebpf agent OOM conditions NETOBSERV-1107: Add GoMemLimit env setting to prevent ebpf agent OOM conditions Jun 21, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 21, 2023

@msherif1234: This pull request references NETOBSERV-1107 which is a valid jira issue.

In response to this:

https://weaviate.io/blog/gomemlimit-a-game-changer-for-high-memory-applications

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jpinsonneau
jpinsonneau previously approved these changes Jun 22, 2023
Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in terms of code, thanks @msherif1234 !

@jotak
Copy link
Member

jotak commented Jun 22, 2023

btw we may do that on FLP as well

@msherif1234
Copy link
Contributor Author

btw we may do that on FLP as well

FLP has memory issues too ?

@openshift-ci openshift-ci bot removed the lgtm label Jun 22, 2023
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jun 22, 2023
jpinsonneau
jpinsonneau previously approved these changes Jul 10, 2023
Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 10, 2023
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@jotak
Copy link
Member

jotak commented Jul 13, 2023

/lgtm
thanks!

@msherif1234
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a4a3c26 into netobserv:main Jul 13, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants