Add nil-check for loki.enable

[jotak]

No description provided.

[codecov]

Codecov Report

Merging #385 (5ce7106) into main (0985c36) will increase coverage by 0.20%.
The diff coverage is 57.28%.

@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
+ Coverage   53.58%   53.79%   +0.20%     
==========================================
  Files          45       45              
  Lines        5488     5515      +27     
==========================================
+ Hits         2941     2967      +26     
- Misses       2337     2340       +3     
+ Partials      210      208       -2     

Flag	Coverage Δ
unittests	53.79% <57.28%> (+0.20%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
api/v1alpha1/flowcollector_webhook.go	0.00% <0.00%> (ø)
api/v1alpha1/zz_generated.conversion.go	0.26% <0.00%> (ø)
api/v1beta1/flowcollector_types.go	100.00% <ø> (ø)
...trollers/consoleplugin/consoleplugin_reconciler.go	62.17% <25.00%> (+1.21%)	⬆️
controllers/flowlogspipeline/flp_common_objects.go	86.58% <80.95%> (-0.02%)	⬇️
api/v1beta1/zz_generated.deepcopy.go	52.72% <100.00%> (+1.09%)	⬆️
pkg/helper/flowcollector.go	70.12% <100.00%> (+2.98%)	⬆️

... and 1 file with indirect coverage changes

[github-actions]

New images:

• quay.io/netobserv/network-observability-operator:262c098
• quay.io/netobserv/network-observability-operator-bundle:v0.0.0-262c098
• quay.io/netobserv/network-observability-operator-catalog:v0.0.0-262c098

They will expire after two weeks.

Catalog source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-262c098
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

[jotak]

I'm not exactly sure when Enable can be nil (upgrade scenario?) - but we should actually consider nil as true, to keep consistency with the default behaviour. So I'll write a new helper method instead

[jotak]

(done)

[jpinsonneau]

thanks @jotak !

[jotak]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jotak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment