-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade linter - fix found issues - use go1.20 #393
Conversation
Codecov Report
@@ Coverage Diff @@
## main #393 +/- ##
==========================================
+ Coverage 54.28% 54.46% +0.17%
==========================================
Files 45 44 -1
Lines 5515 5416 -99
==========================================
- Hits 2994 2950 -44
+ Misses 2315 2259 -56
- Partials 206 207 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are looking good to me, but I think we should also bump the version in the go.mod file since we are not testing 1.18 anymore.
Hmm .. i did that, not sure why it's not in the commit, let me push again :-) |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.