Upgrade linter - fix found issues - use go1.20

[jotak]

No description provided.

[codecov]

Codecov Report

Merging #393 (bf3c866) into main (e2e5337) will increase coverage by 0.17%.
The diff coverage is 68.42%.

@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   54.28%   54.46%   +0.17%     
==========================================
  Files          45       44       -1     
  Lines        5515     5416      -99     
==========================================
- Hits         2994     2950      -44     
+ Misses       2315     2259      -56     
- Partials      206      207       +1     

Flag	Coverage Δ
unittests	54.46% <68.42%> (+0.17%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
api/v1alpha1/flowcollector_webhook.go	0.00% <0.00%> (ø)
controllers/flowcollector_objects.go	37.28% <0.00%> (ø)
...ollers/flowlogspipeline/flp_monolith_reconciler.go	64.28% <ø> (ø)
controllers/flowcollector_controller.go	55.12% <50.00%> (-3.42%)	⬇️
...rollers/flowlogspipeline/flp_transfo_reconciler.go	60.43% <60.00%> (+1.27%)	⬆️
...trollers/consoleplugin/consoleplugin_reconciler.go	63.15% <80.00%> (-0.58%)	⬇️
controllers/flowlogspipeline/flp_common_objects.go	86.58% <100.00%> (ø)
controllers/flowlogspipeline/flp_ingest_objects.go	73.84% <100.00%> (ø)
...trollers/flowlogspipeline/flp_ingest_reconciler.go	66.05% <100.00%> (+1.76%)	⬆️
...ntrollers/flowlogspipeline/flp_monolith_objects.go	88.46% <100.00%> (ø)
... and 1 more

... and 4 files with indirect coverage changes

[OlivierCazade]

Changes are looking good to me, but I think we should also bump the version in the go.mod file since we are not testing 1.18 anymore.

[jotak]

Changes are looking good to me, but I think we should also bump the version in the go.mod file since we are not testing 1.18 anymore.

Hmm .. i did that, not sure why it's not in the commit, let me push again :-)

[jotak]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jotak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment