Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1197: Generalize TCPDrop to include other prototocl drops #396

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

msherif1234
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #396 (10e5022) into main (a4a3c26) will decrease coverage by 0.85%.
The diff coverage is 51.79%.

❗ Current head 10e5022 differs from pull request most recent head cd83838. Consider uploading reports for the commit cd83838 to get more accurate results

@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
- Coverage   54.52%   53.67%   -0.85%     
==========================================
  Files          44       44              
  Lines        5423     5559     +136     
==========================================
+ Hits         2957     2984      +27     
- Misses       2259     2360     +101     
- Partials      207      215       +8     
Flag Coverage Δ
unittests 53.67% <51.79%> (-0.85%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/v1alpha1/flowcollector_webhook.go 0.00% <0.00%> (ø)
api/v1alpha1/zz_generated.conversion.go 0.26% <0.00%> (+<0.01%) ⬆️
api/v1beta1/flowcollector_types.go 100.00% <ø> (ø)
...ntrollers/ebpf/internal/permissions/permissions.go 44.18% <0.00%> (-2.44%) ⬇️
controllers/consoleplugin/consoleplugin_objects.go 95.42% <33.33%> (-1.64%) ⬇️
pkg/helper/flowcollector.go 66.66% <40.00%> (-3.47%) ⬇️
controllers/flowlogspipeline/flp_common_objects.go 81.76% <53.48%> (-4.83%) ⬇️
controllers/ebpf/agent_controller.go 70.70% <58.77%> (-10.36%) ⬇️
api/v1beta1/zz_generated.deepcopy.go 53.77% <100.00%> (+1.05%) ⬆️

... and 1 file with indirect coverage changes

@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 17, 2023
@github-actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:f085a88
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-f085a88
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-f085a88

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:f085a88 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-f085a88

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-f085a88
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 17, 2023
@msherif1234 msherif1234 changed the title Generalize TCPDrop to include other prototocl drops NETOBSERV-1197: Generalize TCPDrop to include other prototocl drops Jul 17, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jul 17, 2023

@msherif1234: This pull request references NETOBSERV-1197 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msherif1234 msherif1234 requested a review from jotak July 18, 2023 01:05
@Amoghrd
Copy link
Contributor

Amoghrd commented Jul 18, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 18, 2023
@github-actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:27d58a6
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-27d58a6
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-27d58a6

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:27d58a6 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-27d58a6

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-27d58a6
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@jotak
Copy link
Member

jotak commented Jul 19, 2023

/lgtm

@msherif1234
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3d0f3b1 into netobserv:main Jul 19, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/valid-reference lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants