Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1233 conntrack reportMissing + DNS response code #401

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Aug 7, 2023

This PR requires netobserv/flowlogs-pipeline#470 to be merged first

Added missing DnsFlagsResponseCode + ReportMissing option for mandatory fields

@jpinsonneau
Copy link
Contributor Author

/hold

@jpinsonneau jpinsonneau added ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. and removed do-not-merge/hold labels Aug 7, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

New images:

  • quay.io/netobserv/network-observability-operator:a3c3d4f
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-a3c3d4f
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-a3c3d4f

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:a3c3d4f make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-a3c3d4f

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-a3c3d4f
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #401 (9a0b936) into main (9d208dd) will increase coverage by 0.00%.
The diff coverage is 78.94%.

@@           Coverage Diff           @@
##             main     #401   +/-   ##
=======================================
  Coverage   55.49%   55.49%           
=======================================
  Files          45       45           
  Lines        5865     5874    +9     
=======================================
+ Hits         3255     3260    +5     
- Misses       2389     2393    +4     
  Partials      221      221           
Flag Coverage Δ
unittests 55.49% <78.94%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
controllers/flowlogspipeline/flp_common_objects.go 81.67% <78.94%> (-0.34%) ⬇️

@msherif1234
Copy link
Contributor

@jpinsonneau why there are lots of other pkg updated in this PR ? I understand the flp update but not sure why u have to update more pkgs ?

@jpinsonneau
Copy link
Contributor Author

@jpinsonneau why there are lots of other pkg updated in this PR ? I understand the flp update but not sure why u have to update more pkgs ?

That's the output of go mod tidy + go mod vendor.
I can get rid of these and only update flp if you prefer 😉

@msherif1234
Copy link
Contributor

/lgtm

@Amoghrd
Copy link
Contributor

Amoghrd commented Aug 7, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Aug 7, 2023
@msherif1234
Copy link
Contributor

/lgtm

@jpinsonneau
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 8, 2023
@openshift-merge-robot openshift-merge-robot merged commit 3e5454d into netobserv:main Aug 8, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants