NETOBSERV-1224 Flowcollector does not report status != Ready in OCP Console #403

jpinsonneau · 2023-08-23T09:06:26Z

Description

Improve CR status update:

Fix condition.Status field. Only the active one should show True
Fix Type field. It will now keep latests Ready / Pending / Failed messages with only one of these True
Added messages
Sorted conditions as oc command only show first item without checking Status field

Screencast.from.2023-08-23.11-15-55.webm

[julien@fedora network-observability-operator]$ oc get flowcollector
NAME      AGENT   SAMPLING (EBPF)   DEPLOYMENT MODEL   STATUS
cluster   EBPF    50                DIRECT             DeploymentInProgress

[julien@fedora network-observability-operator]$ oc get flowcollector
NAME      AGENT   SAMPLING (EBPF)   DEPLOYMENT MODEL   STATUS
cluster   EBPF    50                DIRECT             Ready

Related issues:
https://issues.redhat.com/browse/NETOBSERV-1224
https://issues.redhat.com/browse/NETOBSERV-610

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

github-actions · 2023-08-23T09:12:16Z

New images:

quay.io/netobserv/network-observability-operator:801a9e0
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-801a9e0
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-801a9e0

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:801a9e0 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-801a9e0

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-801a9e0
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

codecov · 2023-08-23T09:18:56Z

Codecov Report

Patch coverage: 64.28% and project coverage change: +0.19% 🎉

Comparison is base (3e5454d) 55.49% compared to head (a0dc9ae) 55.69%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
+ Coverage   55.49%   55.69%   +0.19%     
==========================================
  Files          45       45              
  Lines        5874     5884      +10     
==========================================
+ Hits         3260     3277      +17     
+ Misses       2393     2387       -6     
+ Partials      221      220       -1

Flag	Coverage Δ
unittests	`55.69% <64.28%> (+0.19%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
controllers/flowcollector_controller.go	`52.94% <58.33%> (+0.56%)`	⬆️
pkg/conditions/conditions.go	`27.36% <66.66%> (+13.73%)`	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

msherif1234 · 2023-08-23T13:03:09Z

pkg/conditions/conditions.go

+	cond.Status = metav1.ConditionTrue
+	meta.SetStatusCondition(&fc.Status.Conditions, *cond)
+	sortConditions(fc)
+}


while you are here lets add ut for condition package

Sure I'll do that 👌

I've added some tests but these seems flaky 🤔
fda8f2a

I'm digging to find why:
-> seems to be related to console plugin reconciliation 🤕

@jotak can you please explain the following action ?

network-observability-operator/controllers/flowcollector_controller_test.go

Lines 378 to 381 in 725e26f

// Do a dummy change that will trigger reconcile, and make sure SM is created again

UpdateCR(crKey, func(fc *flowslatest.FlowCollector) {

fc.Spec.Processor.LogLevel = "info"

})

Why do we need to trigger the loop ? Is it a behavior related to the test bench ?

As far as I understand, ginkgo run all of these Context in parallel; that's why I get flaky tests checking the status in the middle of the test bench.
If I check for Ready in Cleanup it works but I also need to trigger the reconcile loop which doesn't make sense to me
a0dc9ae

I cannot recall now, maybe this UpdateCR isn't necessary, but I guess if I added that it's because the kube test env didn't trigger the reconcile as I expected (the goal here being to make sure the ServiceMonitor is recreated - I remember I added this test after a bug where SM wasn't reconciled.

I remember that a while ago I removed some condition-checking code in tests because iirc it wasn't working as expected with kube testenv, and led to flaky tests ... but I don't remember all the details

Amoghrd · 2023-08-23T16:21:36Z

/ok-to-test

github-actions · 2023-08-23T16:26:16Z

New images:

quay.io/netobserv/network-observability-operator:117d5bb
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-117d5bb
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-117d5bb

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:117d5bb make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-117d5bb

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-117d5bb
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

Amoghrd · 2023-08-23T17:02:17Z

/label qe-approved

Amoghrd · 2023-08-25T13:12:00Z

Shoould this be tested again? @jpinsonneau

jpinsonneau · 2023-08-28T07:48:36Z

Shoould this be tested again? @jpinsonneau

No need @Amoghrd, only unit tests were added. I'm just waiting for devs LGTM 😄
Thanks !

jotak

LGTM

jotak · 2023-08-29T08:35:58Z

@jpinsonneau I checked " Does this PR require a product release notes entry? ", I guess it's needed here? If so can you add it to the JIRA?

jpinsonneau · 2023-08-31T16:42:52Z

/approve

openshift-ci · 2023-08-31T16:43:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jpinsonneau]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 23, 2023

improved conditions

f3a3c36

jpinsonneau force-pushed the 1224 branch from 437604f to f3a3c36 Compare August 23, 2023 09:14

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 23, 2023

jpinsonneau requested review from msherif1234 and memodi August 23, 2023 10:47

msherif1234 reviewed Aug 23, 2023

View reviewed changes

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 23, 2023

openshift-ci bot added the qe-approved QE has approved this pull request label Aug 23, 2023

condition status logs & tests

fda8f2a

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 24, 2023

fix flaky tests

a0dc9ae

jotak approved these changes Aug 29, 2023

View reviewed changes

openshift-ci bot assigned jotak Aug 29, 2023

openshift-ci bot added the lgtm label Aug 29, 2023

openshift-ci bot added the approved label Aug 31, 2023

openshift-merge-robot merged commit e647167 into netobserv:main Aug 31, 2023
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NETOBSERV-1224 Flowcollector does not report status != Ready in OCP Console #403

NETOBSERV-1224 Flowcollector does not report status != Ready in OCP Console #403

jpinsonneau commented Aug 23, 2023 •

edited

Loading

github-actions bot commented Aug 23, 2023

codecov bot commented Aug 23, 2023 •

edited

Loading

msherif1234 Aug 23, 2023

jpinsonneau Aug 23, 2023

jpinsonneau Aug 24, 2023 •

edited

Loading

jpinsonneau Aug 24, 2023

jotak Aug 24, 2023

Amoghrd commented Aug 23, 2023

github-actions bot commented Aug 23, 2023

Amoghrd commented Aug 23, 2023

Amoghrd commented Aug 25, 2023

jpinsonneau commented Aug 28, 2023

jotak left a comment

jotak commented Aug 29, 2023

jpinsonneau commented Aug 31, 2023

openshift-ci bot commented Aug 31, 2023

	// Do a dummy change that will trigger reconcile, and make sure SM is created again
	UpdateCR(crKey, func(fc *flowslatest.FlowCollector) {
	fc.Spec.Processor.LogLevel = "info"
	})

NETOBSERV-1224 Flowcollector does not report status != Ready in OCP Console #403

NETOBSERV-1224 Flowcollector does not report status != Ready in OCP Console #403

Conversation

jpinsonneau commented Aug 23, 2023 • edited Loading

Description

Dependencies

Checklist

github-actions bot commented Aug 23, 2023

codecov bot commented Aug 23, 2023 • edited Loading

Codecov Report

msherif1234 Aug 23, 2023

Choose a reason for hiding this comment

jpinsonneau Aug 23, 2023

Choose a reason for hiding this comment

jpinsonneau Aug 24, 2023 • edited Loading

Choose a reason for hiding this comment

jpinsonneau Aug 24, 2023

Choose a reason for hiding this comment

jotak Aug 24, 2023

Choose a reason for hiding this comment

Amoghrd commented Aug 23, 2023

github-actions bot commented Aug 23, 2023

Amoghrd commented Aug 23, 2023

Amoghrd commented Aug 25, 2023

jpinsonneau commented Aug 28, 2023

jotak left a comment

Choose a reason for hiding this comment

jotak commented Aug 29, 2023

jpinsonneau commented Aug 31, 2023

openshift-ci bot commented Aug 31, 2023

jpinsonneau commented Aug 23, 2023 •

edited

Loading

codecov bot commented Aug 23, 2023 •

edited

Loading

jpinsonneau Aug 24, 2023 •

edited

Loading