Remove ConfigOrSecret API, replaced with the newer FileReference

[jotak]

Description

This PR is based on #379 (not merged yet), cc @OlivierCazade

Remove ConfigOrSecret API, replaced with the newer FileReference
This only impacts SASL config which is not supported product-wise

If a user was using SASL despite its unsupported status, for migration, it is necessary to adapt the FlowCollector config, as per new CRD documentation.

E.g. This old config:

    sasl:
      type: PLAIN
      reference:
        type: secret
        name: flp-kafka-sasl
      clientIDKey: clientId
      clientSecretKey: clientSecret

should be changed into:

    sasl:
      type: PLAIN
      clientIDReference:
        type: secret
        name: flp-kafka-sasl
        file: clientId
      clientSecretReference:
        type: secret
        name: flp-kafka-sasl
        file: clientSecret

Dependencies

n/a

Checklist

Unsupported feature product-wise, so no QE/doc involved

[codecov]

Codecov Report

Patch coverage: 58.33% and project coverage change: +0.12% 🎉

Comparison is base (7aa9ff7) 55.57% compared to head (6e5391e) 55.70%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
+ Coverage   55.57%   55.70%   +0.12%     
==========================================
  Files          46       46              
  Lines        5954     5960       +6     
==========================================
+ Hits         3309     3320      +11     
+ Misses       2417     2410       -7     
- Partials      228      230       +2     

Flag	Coverage Δ
unittests	55.70% <58.33%> (+0.12%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
api/v1beta1/flowcollector_types.go	100.00% <ø> (ø)
api/v1beta1/zz_generated.deepcopy.go	53.10% <0.00%> (+0.89%)	⬆️
controllers/ebpf/agent_controller.go	73.15% <0.00%> (-0.44%)	⬇️
pkg/watchers/watcher.go	72.03% <40.00%> (-3.43%)	⬇️
controllers/flowlogspipeline/flp_common_objects.go	80.68% <100.00%> (+1.68%)	⬆️
controllers/flowlogspipeline/flp_reconciler.go	69.49% <100.00%> (+1.63%)	⬆️
pkg/volumes/builder.go	100.00% <100.00%> (ø)
pkg/watchers/object_ref.go	100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

[jotak]

FYI I tested a deployment with this SASL config: verified that ebpf & flp pods are correctly deployed with correct configuration and volumes correctly mounted

[OlivierCazade]

LGTM, thanks!

[jotak]

thanks!
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jotak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment