-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ConfigOrSecret API, replaced with the newer FileReference #411
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #411 +/- ##
==========================================
+ Coverage 55.57% 55.70% +0.12%
==========================================
Files 46 46
Lines 5954 5960 +6
==========================================
+ Hits 3309 3320 +11
+ Misses 2417 2410 -7
- Partials 228 230 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
32729de
to
91bf07a
Compare
This only impacts SASL config which is not supported product-wise
91bf07a
to
6e5391e
Compare
FYI I tested a deployment with this SASL config: verified that ebpf & flp pods are correctly deployed with correct configuration and volumes correctly mounted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR is based on #379 (not merged yet), cc @OlivierCazade
Remove ConfigOrSecret API, replaced with the newer FileReference
This only impacts SASL config which is not supported product-wise
If a user was using SASL despite its unsupported status, for migration, it is necessary to adapt the
FlowCollector
config, as per new CRD documentation.E.g. This old config:
should be changed into:
Dependencies
n/a
Checklist
Unsupported feature product-wise, so no QE/doc involved