NETOBSERV-1295: Fix cacert monitoring copy

[OlivierCazade]

Description

Add certificate copy to monitoring namespace.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[openshift-ci-robot]

@OlivierCazade: This pull request references NETOBSERV-1295 which is a valid jira issue.

In response to this:

Description

Add certificate copy to monitoring namespace.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
• If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
• If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
• If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Patch coverage: 5.40% and project coverage change: -0.82% ⚠️

Comparison is base (ba06996) 56.22% compared to head (a83fe15) 55.41%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
- Coverage   56.22%   55.41%   -0.82%     
==========================================
  Files          46       46              
  Lines        5960     5995      +35     
==========================================
- Hits         3351     3322      -29     
- Misses       2383     2438      +55     
- Partials      226      235       +9     

Flag	Coverage Δ
unittests	55.41% <5.40%> (-0.82%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
controllers/flowcollector_objects.go	46.91% <0.00%> (ø)
...trollers/flowlogspipeline/flp_ingest_reconciler.go	64.28% <0.00%> (-1.77%)	⬇️
...ollers/flowlogspipeline/flp_monolith_reconciler.go	64.00% <0.00%> (-1.58%)	⬇️
...rollers/flowlogspipeline/flp_transfo_reconciler.go	60.14% <0.00%> (-1.34%)	⬇️
pkg/watchers/watcher.go	64.39% <0.00%> (-12.73%)	⬇️
controllers/flowlogspipeline/flp_reconciler.go	60.56% <16.66%> (-8.93%)	⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jotak]

code lgtm

[memodi]

/ok-to-test

[github-actions]

New images:

• quay.io/netobserv/network-observability-operator:95e04c9
• quay.io/netobserv/network-observability-operator-bundle:v0.0.0-95e04c9
• quay.io/netobserv/network-observability-operator-catalog:v0.0.0-95e04c9

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:95e04c9 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-95e04c9

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-95e04c9
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

[memodi]

what are these hard coded values for?

[OlivierCazade]

Constants for monitoring namespace and monitoring role, they were already there, I just moved them to the constant file since they are now used at different places.

[memodi]

@OlivierCazade - I am still getting error with the Operator image from this PR:

Warning FailedMount 3s (x6 over 18s) kubelet MountVolume.SetUp failed for volume "prom-certs" : configmap "prov-certs-ns" not found

$ oc get csv/netobserv-operator.v0.0.0-95e04c9 -n openshift-netobserv-operator -o yaml | egrep -A 1 "DOWN"
                - --downstream-deployment=$(DOWNSTREAM_DEPLOYMENT)
                command:
--
                - name: DOWNSTREAM_DEPLOYMENT
                  value: "true"

OCP: 4.14.0-0.nightly-2023-09-12-024050
NetObserv operator: v0.0.0-95e04c9
Loki: 0-click-loki
eBPF-agent: main
FLP: main
ConsolePlugin: main

Using config:

          tls:
            insecureSkipVerify: false
            provided:
              certFile: tls.crt
              certKey: tls.key
              name: prov-certs-ns
              namespace: netobserv-cm
              type: configmap
            providedCaFile:
              file: rootCA.crt
              name: prov-certs-ca-ns
              namespace: netobserv-cm
              type: configmap
            type: PROVIDED

$ oc get cm -n netobserv-cm
NAME                       DATA   AGE
kube-root-ca.crt           1      8m48s
openshift-service-ca.crt   1      8m48s
prov-certs-ca-ns           1      7m56s
prov-certs-ns              2      8m5s

[OlivierCazade]

Thanks @memodi.

My initial PR was to fix the CaCert copy when in a different namespace, but it turn out there was also a bug with the old provided certs when they are also in a different namespace.

Updated PR should resolve both.

[memodi]

/ok-to-test

[github-actions]

New images:

• quay.io/netobserv/network-observability-operator:60dfe0a
• quay.io/netobserv/network-observability-operator-bundle:v0.0.0-60dfe0a
• quay.io/netobserv/network-observability-operator-catalog:v0.0.0-60dfe0a

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:60dfe0a make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-60dfe0a

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-60dfe0a
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

[memodi]

/ok-to-test

[github-actions]

New images:

• quay.io/netobserv/network-observability-operator:47510aa
• quay.io/netobserv/network-observability-operator-bundle:v0.0.0-47510aa
• quay.io/netobserv/network-observability-operator-catalog:v0.0.0-47510aa

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:47510aa make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-47510aa

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-47510aa
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

[memodi]

/label qe-approved

[OlivierCazade]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: OlivierCazade

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [OlivierCazade]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment