-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate flow json spec #417
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #417 +/- ##
==========================================
+ Coverage 55.32% 55.41% +0.08%
==========================================
Files 46 46
Lines 5995 5995
==========================================
+ Hits 3317 3322 +5
+ Misses 2443 2438 -5
Partials 235 235
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jotak everything looks OK except a couple of minor inconsistencies that I'd like to keep the same in my file:
-
for line 3 & 4: I have this in my file and I would like to keep it that way:
[id="network-observability-flows-format_{context}"]
= Network Flows format reference -
For line 10, I have this in my file, and I think it was peer reviewed to be like this, maybe we didn't synch it:
If you are reading this specification as a reference for the Kafka export feature, you must treat all Labels and Fields as regular fields and ignore any distinctions between them that are specific to Loki.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, this is in the header file, I'll update it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done: 8760c99
@skrthomas I fixed the InterfaceDirection xref issue that makes your PR fails https://app.travis-ci.com/github/openshift/openshift-docs/jobs/609884831 |
1bdbb8d
to
f6034a7
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Consolidate json spec following netobserv/network-observability-console-plugin#383
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.