NETOBSERV-791 Better organize OLM form #425
Conversation
jpinsonneau
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
jpinsonneau
added
the
ok-to-test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
==========================================
- Coverage 57.73% 57.63% -0.11%
==========================================
Files 70 70
Lines 9446 9446
==========================================
- Hits 5454 5444 -10
- Misses 3659 3666 +7
- Partials 333 336 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-actions
bot
removed
the
ok-to-test
jpinsonneau
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
jpinsonneau
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
jpinsonneau
added
the
ok-to-test
|
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:185ed33 make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-185ed33Or as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-185ed33
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
github-actions
bot
removed
the
ok-to-test
Yeah I agree, there are pros and cons, but it looks so much better! What do you think about "promoting" some fields at the top level? E.g. sampling? |
convert checkboxes to switch console plugin display only when loki enabled update bundle rebased / apply to v1beta2
|
@jpinsonneau FYI I'm rebasing it and adapting to v1beta2 ... |
Thanks @jotak |
Hide some of them (e.g. ipfix), move others in advanced
jotak
added
the
ok-to-test
|
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:ebd5d32 make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-ebd5d32Or as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-ebd5d32
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
github-actions
bot
removed
the
ok-to-test
jotak
added
the
ok-to-test
|
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:2f30838 make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-2f30838Or as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-2f30838
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
github-actions
bot
removed
the
ok-to-test
jotak
added
the
ok-to-test
|
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:8fdb437 make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-8fdb437Or as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-8fdb437
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
|
@jpinsonneau - I am able to see changes in form view, however I am not seeing the flowcollector details as you have shown in screenshot, I see as below. Am I missing something?
|
The image is probably outdated but you should see the difference when you click on To allow these changes on view / edit mode, OCP console requires the following fix: openshift/console#13181 I don't expect this to be merged soon so let's just focus on create form. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Added to CSV:
This is made using a complex mechanism relying on required fields / dependencies between fields and falling back on the number of subfields. I would suggest to keep it as is.
see related discussion and OCPBUGS-19541: Console Operand not working for clusterwide CRDs openshift/console#13181
These will make the CSV harder to maintain but the UX is way better in the console.
Dependencies
#329
#467
#522
Will need update for
v1beta2APIChecklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.