NETOBSERV-1314: cleanup old objects after upgrade [1.4 backport] #429
Conversation
Add more tests Also fixes an issue with the kube client mock assertions: some assertions on function calls didn't have the intended effect when used with the wrong number of arguments
|
@jotak: This pull request references NETOBSERV-1314 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-1.4 #429 +/- ##
==============================================
Coverage ? 55.61%
==============================================
Files ? 47
Lines ? 6063
Branches ? 0
==============================================
Hits ? 3372
Misses ? 2452
Partials ? 239
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport of #427