Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small doc updates - feedback from osdocs #430

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Sep 22, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5fa0717) 54.91% compared to head (8b1c54b) 55.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
+ Coverage   54.91%   55.11%   +0.20%     
==========================================
  Files          47       47              
  Lines        6381     6381              
==========================================
+ Hits         3504     3517      +13     
+ Misses       2635     2626       -9     
+ Partials      242      238       -4     
Flag Coverage Δ
unittests 55.11% <ø> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/v1beta1/flowcollector_types.go 100.00% <ø> (ø)
api/v1beta2/flowcollector_types.go 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotak
Copy link
Member Author

jotak commented Oct 11, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 707ab18 into netobserv:main Oct 11, 2023
9 checks passed
@jotak jotak deleted the doc-update-next branch November 1, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants