Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1340: Add operator to "Networking" category in OperatorHub #451

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

stleerh
Copy link
Contributor

@stleerh stleerh commented Oct 5, 2023

There is a request to also add Network Observability to the "Networking" category.

See #440 for related details.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 5, 2023

@stleerh: This pull request references NETOBSERV-1340 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "netobserv-1.5" instead.

In response to this:

There is a request to also add Network Observability to the "Networking" category.

See #440 for related details.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (87a34ad) 54.92% compared to head (989d35c) 54.92%.
Report is 25 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #451   +/-   ##
=======================================
  Coverage   54.92%   54.92%           
=======================================
  Files          47       47           
  Lines        6382     6382           
=======================================
  Hits         3505     3505           
  Misses       2635     2635           
  Partials      242      242           
Flag Coverage Δ
unittests 54.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotak
Copy link
Member

jotak commented Oct 10, 2023

/lgtm

@jotak
Copy link
Member

jotak commented Oct 13, 2023

@stleerh : I had to revert your previous PR adding to Observability category, as this isn't a recognized category.
Do you know if there is an ongoing change somewhere (OLM?) to create this category? I guess we need first to have this category created before we can add it here - not doing so generates validation failures (unstable downstream builds).

Adding to "Networking" is fine I guess, since this category already exists; you'll need to rebase the PR to fix conflict though

@jotak
Copy link
Member

jotak commented Oct 13, 2023

(I resolved the conflict via github)

@jotak
Copy link
Member

jotak commented Nov 13, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Nov 13, 2023
Copy link

openshift-ci bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c76eaa1 into netobserv:main Nov 13, 2023
9 checks passed
Amoghrd pushed a commit to Amoghrd/network-observability-operator that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants