Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETOBSERV-1326: NETOBSERV-1231: Drops & RTT metrics #453

Merged
merged 5 commits into from
Nov 10, 2023
Merged

NETOBSERV-1326: NETOBSERV-1231: Drops & RTT metrics #453

merged 5 commits into from
Nov 10, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Oct 9, 2023 •
edited

PR based-on #447 , which must be merged first
For this PR alone, check commit d270abf

Description

  • Added metrics: node_rtt_seconds, namespace_rtt_seconds, workload_rtt_seconds,
    node_drop_packets_total, node_drop_bytes_total,
    namespace_drop_packets_total, namespace_drop_bytes_total,
    workload_drop_packets_total, workload_drop_bytes_total
  • Add dashboards for drops (not yet for RTT, need to handle histomgrams
    in dashboards first)

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@jotak jotak changed the title Rtt drops metrics NETOBSERV-1326: NETOBSERV-1231: Drops & RTT metrics Oct 9, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 9, 2023 •
edited by openshift-ci bot

@jotak: This pull request references NETOBSERV-1326 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "netobserv-1.5" instead.

In response to this:

PR based-on #447 , which must be merged first

Description

  • Added metrics: node_rtt, namespace_rtt, workload_rtt,
    node_drop_packets_total, node_drop_bytes_total,
    namespace_drop_packets_total, namespace_drop_bytes_total,
    workload_drop_packets_total, workload_drop_bytes_total
  • Add dashboards for drops (not yet for RTT, need to handle histomgrams
    in dashboards first)

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 9, 2023 •
edited by openshift-ci bot

@jotak: This pull request references NETOBSERV-1326 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "netobserv-1.5" instead.

In response to this:

PR based-on #447 , which must be merged first
For this PR alone, check commit d270abf

Description

  • Added metrics: node_rtt, namespace_rtt, workload_rtt,
    node_drop_packets_total, node_drop_bytes_total,
    namespace_drop_packets_total, namespace_drop_bytes_total,
    workload_drop_packets_total, workload_drop_bytes_total
  • Add dashboards for drops (not yet for RTT, need to handle histomgrams
    in dashboards first)

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msherif1234
Copy link
Contributor

Drop changes LGTM

@jotak
NETOBSERV-1326: NETOBSERV-1231: Drops & RTT metrics
c63c8aa 
- Added metrics: node_rtt, namespace_rtt, workload_rtt,
  node_drop_packets_total, node_drop_bytes_total,
namespace_drop_packets_total, namespace_drop_bytes_total,
workload_drop_packets_total, workload_drop_bytes_total
- Add dashboards for drops (not yet for RTT, need to handle histomgrams
  in dashboards first)
@jotak
Update CRD doc and tests with added metrics
7286588
@jotak jotak marked this pull request as ready for review November 8, 2023 14:38
@msherif1234
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 8, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 8, 2023 •
edited by openshift-ci bot

@jotak: This pull request references NETOBSERV-1326 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

PR based-on #447 , which must be merged first
For this PR alone, check commit d270abf

Description

  • Added metrics: node_rtt_seconds, namespace_rtt_seconds, workload_rtt_seconds,
    node_drop_packets_total, node_drop_bytes_total,
    namespace_drop_packets_total, namespace_drop_bytes_total,
    workload_drop_packets_total, workload_drop_bytes_total
  • Add dashboards for drops (not yet for RTT, need to handle histomgrams
    in dashboards first)

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the lgtm label Nov 8, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 8, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (74a4814) 62.26% compared to head (6c7662e) 62.56%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
+ Coverage   62.26%   62.56%   +0.29%     
==========================================
  Files          55       55              
  Lines        6769     6822      +53     
==========================================
+ Hits         4215     4268      +53     
  Misses       2238     2238              
  Partials      316      316
Flag Coverage Δ
unittests 62.56% <100.00%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/v1beta1/flowcollector_types.go 100.00% <ø> (ø)
api/v1beta2/flowcollector_types.go 100.00% <ø> (ø)
pkg/dashboards/dashboard.go 98.70% <100.00%> (+0.07%) ⬆️
pkg/metrics/predefined_metrics.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msherif1234
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 8, 2023
@Amoghrd
Copy link
Contributor

Amoghrd commented Nov 9, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 9, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

New images:

  • quay.io/netobserv/network-observability-operator:6bbedc2
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-6bbedc2
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-6bbedc2

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:6bbedc2 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-6bbedc2

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-6bbedc2
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@msherif1234
Copy link
Contributor

While you are here might not be bad idea adding dns latency metrics and customer can use that to trigger alerts if latency is more than 20 Ms for example

@openshift-ci openshift-ci bot removed the lgtm label Nov 10, 2023
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 10, 2023
@jotak
Copy link
Member Author

jotak commented Nov 10, 2023

@msherif1234 yeah that's planned in another JIRA (https://issues.redhat.com/browse/NETOBSERV-1334) so for another PR

@Amoghrd
Copy link
Contributor

Amoghrd commented Nov 10, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 10, 2023
@github-actions GitHub Actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:2c27e30
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-2c27e30
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-2c27e30

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:2c27e30 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-2c27e30

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-2c27e30
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@Amoghrd
Copy link
Contributor

Amoghrd commented Nov 10, 2023

/lgtm
/label qe-approved

@openshift-ci openshift-ci bot added qe-approved QE has approved this pull request lgtm labels Nov 10, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 10, 2023 •
edited by openshift-ci bot

@jotak: This pull request references NETOBSERV-1326 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

PR based-on #447 , which must be merged first
For this PR alone, check commit d270abf

Description

  • Added metrics: node_rtt_seconds, namespace_rtt_seconds, workload_rtt_seconds,
    node_drop_packets_total, node_drop_bytes_total,
    namespace_drop_packets_total, namespace_drop_bytes_total,
    workload_drop_packets_total, workload_drop_bytes_total
  • Add dashboards for drops (not yet for RTT, need to handle histomgrams
    in dashboards first)

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jotak
Copy link
Member Author

jotak commented Nov 10, 2023

Thanks @Amoghrd !
/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 706566b into netobserv:main Nov 10, 2023
11 checks passed
Amoghrd pushed a commit to Amoghrd/network-observability-operator that referenced this pull request Dec 7, 2023
@jotak @Amoghrd
NETOBSERV-1326: NETOBSERV-1231: Drops & RTT metrics (netobserv#453)
3414c8f 
* NETOBSERV-1326: NETOBSERV-1231: Drops & RTT metrics

- Added metrics: node_rtt, namespace_rtt, workload_rtt,
  node_drop_packets_total, node_drop_bytes_total,
namespace_drop_packets_total, namespace_drop_bytes_total,
workload_drop_packets_total, workload_drop_bytes_total
- Add dashboards for drops (not yet for RTT, need to handle histomgrams
  in dashboards first)

* Update CRD doc and tests with added metrics

* Set new defaults

* Update CRD doc

* externalize metrics doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amoghrd Amoghrd Amoghrd left review comments

@msherif1234 msherif1234 Awaiting requested review from msherif1234

@jpinsonneau jpinsonneau Awaiting requested review from jpinsonneau

Assignees

@msherif1234 msherif1234

@Amoghrd Amoghrd

Labels
approved jira/valid-reference lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jotak @openshift-ci-robot @msherif1234 @Amoghrd