NETOBSERV-1369: Disable http/2 #466
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
==========================================
+ Coverage 54.95% 54.97% +0.02%
==========================================
Files 47 47
Lines 6460 6463 +3
==========================================
+ Hits 3550 3553 +3
Misses 2668 2668
Partials 242 242
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
@jotak: This pull request references NETOBSERV-1369 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jotak
added
the
ok-to-test
|
@jotak: This pull request references NETOBSERV-1369 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jotak: This pull request references NETOBSERV-1369 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:b59602c make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-b59602cOr as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-b59602c
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
jotak
added
the
no-doc
.github/workflows/pull_request.yml
Outdated
| @@ -10,7 +10,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| go: ['1.19','1.20'] | |||
| go: ['1.20','1.21'] | |||
There was a problem hiding this comment.
u need to modify go: ['1.20']in the other yml files to be go: ['1.21']
workflows/pull_request.yml: if: ${{ matrix.go == '1.20' }}
workflows/push_image_pr.yml: go: ['1.20']
workflows/release.yml: go: ['1.20']
workflows/push_image.yml: go: ['1.20']
workflows/push_image.yml: go: ['1.20']There was a problem hiding this comment.
no, we keep using 1.20 as the main one, since this is what's still used atm for image builds. 1.21 is like a "preview" atm
github-actions
bot
removed
the
ok-to-test
Additional remediations for CVE-2023-39325 CVE-2023-44487: Disable HTTP/2 on: - Webhook server - Metrics server - FLP and Console plugin via env GODEBUG Also bump all k8s / contorller-runtime dependencies Stop support for go1.19, add support for go1.21 (still uses 1.20 for builds)
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:3988939 make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-3988939Or as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-3988939
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
|
/label qe-approved |
|
@jotak: This pull request references NETOBSERV-1369 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Additional remediations for CVE-2023-39325 CVE-2023-44487: Disable HTTP/2 on:
Also bump all k8s / contorller-runtime dependencies Stop support for go1.19, add support for go1.21 (still uses 1.20 for builds)
Description
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.