Update for FLP API breaking change

[jotak]

Related to netobserv/flowlogs-pipeline#513

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (74a4814) 62.26% compared to head (fa593dd) 62.26%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #487   +/-   ##
=======================================
  Coverage   62.26%   62.26%           
=======================================
  Files          55       55           
  Lines        6769     6769           
=======================================
  Hits         4215     4215           
  Misses       2238     2238           
  Partials      316      316           

Flag	Coverage Δ
unittests	62.26% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
pkg/metrics/predefined_metrics.go	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[msherif1234]

overall changes /LGTM just wanted to understand why flowdirection is using regex filter type
/LGTM

[jotak]

overall changes /LGTM just wanted to understand why flowdirection is using regex filter type /LGTM

It was previously using this sort of things: FlowDirection: "0|2", the "|" character being implicitly used to allow multiple values. The FLP PR changed that for something more explicit and allowing any regex.

So the filter value is still the same, like "0|2", but now this is processed as a regex and the special case handling for "|" is removed

[jotak]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jotak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment