Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETOBSERV-1404: mitigate narrowcache weakness on missed events #504

Merged
merged 2 commits into from
Dec 2, 2023
Merged

NETOBSERV-1404: mitigate narrowcache weakness on missed events #504

merged 2 commits into from
Dec 2, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Nov 30, 2023

Description

narrowcache might contain outdated data in case of missed events, add a mechanism to invalidate entries on errors

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@jotak jotak requested a review from Amoghrd November 30, 2023 14:12
@codecov Codecov
Copy link

codecov bot commented Nov 30, 2023 •
edited

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (654de83) 64.45% compared to head (68cb03d) 64.52%.

Files Patch % Lines
pkg/narrowcache/client.go 79.16% 8 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
+ Coverage   64.45%   64.52%   +0.07%     
==========================================
  Files          58       58              
  Lines        7022     7065      +43     
==========================================
+ Hits         4526     4559      +33     
- Misses       2187     2195       +8     
- Partials      309      311       +2
Flag Coverage Δ
unittests 64.52% <79.16%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotak
NETOBSERV-1404 mitigate narrowcache weakness on missed events
ccf1b73 
narrowcache might contain outdated data in case of missed events, add a
mechanism to invalidate entries on errors
@Amoghrd
Copy link
Contributor

Amoghrd commented Nov 30, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 30, 2023
@github-actions GitHub Actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:916189c
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-916189c
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-916189c

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:916189c make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-916189c

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-916189c
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@Amoghrd
Copy link
Contributor

Amoghrd commented Nov 30, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Nov 30, 2023
@jotak jotak changed the title NETOBSERV-1404 mitigate narrowcache weakness on missed events NETOBSERV-1404: mitigate narrowcache weakness on missed events Dec 1, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 1, 2023 •
edited by openshift-ci bot

@jotak: This pull request references NETOBSERV-1404 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

Description

narrowcache might contain outdated data in case of missed events, add a mechanism to invalidate entries on errors

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jotak
Fix other potential issues:
68cb03d 
- defer Unlocks
- in case where a watch stops, remove the cache entry, so a new "get"
  would recreate it
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 1, 2023
@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 1, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

New images:

  • quay.io/netobserv/network-observability-operator:61ee1a0
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-61ee1a0
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-61ee1a0

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:61ee1a0 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-61ee1a0

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-61ee1a0
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

OlivierCazade
OlivierCazade approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Dec 1, 2023
@Amoghrd
Copy link
Contributor

Amoghrd commented Dec 1, 2023

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Amoghrd
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak merged commit 7ad130e into netobserv:main Dec 2, 2023
8 of 9 checks passed
@jotak jotak deleted the ncache-weak branch December 6, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierCazade OlivierCazade OlivierCazade approved these changes

@Amoghrd Amoghrd Awaiting requested review from Amoghrd

@jpinsonneau jpinsonneau Awaiting requested review from jpinsonneau

Assignees

@OlivierCazade OlivierCazade

Labels
jira/valid-reference lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jotak @Amoghrd @openshift-ci-robot @OlivierCazade