NETOBSERV-107 Add version information #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
version information is added in several places: - via kustomize, as label on the operator (manager) itself - through build ldflags, to the main package, logged for information (both in "make build" and "make image-build") - in deployed components (goflow-kube and console plugin) as k8s label (note that the version here is taken from the images defined in CR, which can be different from the operator version) Use the VERSION env in make targets to set a specific version (e.g. VERSION="0.1.0-test" IMAGE_TAG_BASE="quay.io/jotak/network-observability-operator" make image-build image-push deploy)
|
FYI I had to upgrade kustomize but it seems that we need to manually remove it from our go bin path and This PR is only a part of the changes needed for NETOBSERV-107. More work is needed on CI side. Potentially also in goflow-kube / console plugin |
mariomac
approved these changes
Feb 7, 2022
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
KalmanMeth
pushed a commit
to KalmanMeth/network-observability-operator
that referenced
this pull request
Feb 13, 2023
improve the code ...adding packets and SequenceNum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA https://issues.redhat.com/browse/NETOBSERV-107
version information is added in several places:
(both in "make build" and "make image-build")
(note that the version here is taken from the images defined in CR, which can
be different from the operator version)
make create-sampleso that it can use a custom version from envUse the VERSION env in make targets to set a specific version
(e.g.
VERSION="0.1.0-test" IMAGE_TAG_BASE="quay.io/jotak/network-observability-operator" make image-build image-push deploy)