-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV: 1374 fix pascal case exception in sample #518
NETOBSERV: 1374 fix pascal case exception in sample #518
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #518 +/- ##
=======================================
Coverage 66.76% 66.76%
=======================================
Files 64 64
Lines 7523 7523
=======================================
Hits 5023 5023
Misses 2182 2182
Partials 318 318
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yeah ran into the same with latest yesterday |
@nathan-weinberg @Amoghrd I don't think you use this sample CR. Is it good for you to merge ? |
yeah we dont use this CR, unless deploying with make commands(which I dont use much personally) |
Ok I'm merging this then 😃 thanks ! |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jpinsonneau +1 to what @Amoghrd said but thank you for checking! 🙏 |
Description
Following Sara's comment I noticed I made a mistake in the sample CR.
We should use
eBPF
andIPFIX
. Only the sample CR is affected.Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.