Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix to use OPERATOR_NS instead #539

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Conversation

memodi
Copy link
Contributor

@memodi memodi commented Jan 25, 2024

fixes following #535

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5cef5ac) 57.84% compared to head (320ef60) 57.78%.

❗ Current head 320ef60 differs from pull request most recent head 23cf30c. Consider uploading reports for the commit 23cf30c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
- Coverage   57.84%   57.78%   -0.06%     
==========================================
  Files          72       72              
  Lines        9524     9506      -18     
==========================================
- Hits         5509     5493      -16     
+ Misses       3679     3677       -2     
  Partials      336      336              
Flag Coverage Δ
unittests 57.78% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good catch @memodi ! Thanks

Copy link

openshift-ci bot commented Jan 26, 2024

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b52cbd1 into netobserv:main Jan 26, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants